chore: add pr branch validation working for main branch#168
Closed
vicheey wants to merge 3 commits into
Closed
Conversation
vicheey
had a problem deploying
to
integ-tests
GitHub Actions
Failure
vicheey
had a problem deploying
to
integ-tests
GitHub Actions
Failure
vicheey
had a problem deploying
to
integ-tests
GitHub Actions
Failure
vicheey
had a problem deploying
to
integ-tests
GitHub Actions
Failure
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
I get why we would add this, but is this something we should be doing in all of our repos? It seems like a marginal improvement at best so I feel like it's not necessary, but I might not understand the RIE use case as well. |
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
vicheey
had a problem deploying
to
integ-tests
GitHub Actions
Failure
vicheey
had a problem deploying
to
integ-tests
GitHub Actions
Failure
vicheey
had a problem deploying
to
integ-tests
GitHub Actions
Failure
vicheey
had a problem deploying
to
integ-tests
GitHub Actions
Failure
Contributor
Author
I feel the need to add this because there were incident that commits that were ported indirectly into main for release, skipping development branch. |
|
We discussed a little offline, I think we might move to merging directly to main rather than through develop in those instances. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add branch validation for PR merging into main. Only PR from develop branch allowed.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.